Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support version active lts or latest #16

Merged
merged 8 commits into from
Nov 26, 2018
Merged

Support version active lts or latest #16

merged 8 commits into from
Nov 26, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Nov 23, 2018

  • update eslint
  • update eslint-config-hexo
  • define engines field
  • fix lint error

@segayuu segayuu requested a review from a team November 23, 2018 10:19
@coveralls
Copy link

coveralls commented Nov 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3848e2c on segayuu:support-version-active-lts-or-latest into 9e5e7ae on hexojs:master.

@segayuu
Copy link
Contributor Author

segayuu commented Nov 23, 2018

https://travis-ci.com/segayuu/hexo-generator-archive/jobs/160470115#L451
nunjacks not supported node@11.2

@JLHwung
Copy link
Contributor

JLHwung commented Nov 23, 2018

nunjacks not supported node@11.2

The issue was raised to mozilla/nunjucks#1168

@tomap
Copy link
Contributor

tomap commented Nov 24, 2018

Maybe you should stick to node 10 so that we are not blocked by mozilla/nunjucks being late with updates

tomap
tomap approved these changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@tomap tomap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i'm not sure why you did not simply use node >= 6.9

@segayuu
Copy link
Contributor Author

segayuu commented Nov 25, 2018

@tomap The reason not to define> = 6.9 is to clarify that we do not support 7 and 9 which have already ended support.

@segayuu
Copy link
Contributor Author

segayuu commented Nov 25, 2018

hexojs/site#798 (comment)
A ci error could be avoided by the same method as this comment.
However, it means that we can not do ci automatic test in the latest version.

@segayuu segayuu merged commit 74404b8 into hexojs:master Nov 26, 2018
@segayuu segayuu deleted the support-version-active-lts-or-latest branch November 26, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@segayuu @coveralls @JLHwung @tomap