-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generate sitemap.txt
#136
Conversation
- default generate `sitemap.txt` and `sitemap.xml` - `generator.js` judge `path` string or array - `template.js` `extname(path)` to chose template ``` sitemap: path: - sitemap.xml - sitemap.txt #remove it to disable template_txt: sitemap.txt #(optional) ```
testcode: fix generator.js coverage branch coverage 100% and add txt test.
Looks ok. In which case would you need a txt file? |
Looks ok. I. Which case would you need a txt file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uiolee
Thank you for your contribution :)
Would you please delete a comment out code?
And please update the options section in the README.
According to the Sitemaps specifications, it can be provided as text file. IMHO we can accept this because this PR is based on the specifications. |
txt file function as xml file. a few search engines support both xml and txt. in my own case, i summit both txt and xml file to search engines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We published a new version.
|
This reverts commit 4e89ead.
sitemap.txt
sitemap.txt
sitemap.txt
andsitemap.xml
generator.js
add judgepath
string or arraytemplate.js
addextname(path)
to chose template