-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove babel and mjs #94
Conversation
The travis CI error could not be confirmed locally. |
I can reproduce test failure on my machine. The test fixture is highly related to the output of hexo helpers and highlight.js. Since As long as Could you enable the skipped |
I don't know how to adapt the review.
|
@segayuu
Please be careful, npm script might be a failure on native Windows if execute Please delete |
Line ending difference? |
Maybe I got it. The test failure caused by The test success on Linux (WSL) if npm-script preset:clone change to following. "pretest:clone": "git clone --recursive https://github.com/hexojs/hexo-starter.git ./test/site && cd ./test/site && git checkout a4d53738d734b1151576337ea427b6186115943a" The commit hash a4d53738d734b1151576337ea427b6186115943a is parent commit of update hexo-renderer-marked to v1.0.1
Maybe no. But, I don't know why the test passes on native Windows. That's weird 🤔 |
b0a03aa
to
cd275ca
Compare
cd275ca
to
8926033
Compare
Thank @yoshinorin ! |
similar issue with hexojs/hexo#3571? |
No description provided.