Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: anchorAlias option to set custom header id #172

Merged
merged 1 commit into from
Sep 25, 2020
Merged

feat: anchorAlias option to set custom header id #172

merged 1 commit into from
Sep 25, 2020

Conversation

curbengh
Copy link
Contributor

Requested by #60 (comment) @sinkcup
Based on #60 credit @mdluo

@coveralls
Copy link

coveralls commented Sep 19, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a32e36a on curbengh:custom-anchor into 9058e8b on hexojs:master.

@curbengh curbengh requested review from SukkaW and removed request for SukkaW September 24, 2020 08:17
@curbengh curbengh requested a review from SukkaW September 24, 2020 08:19
SukkaW
SukkaW reviewed Sep 24, 2020
View reviewed changes
README.md Show resolved Hide resolved
@curbengh curbengh requested a review from SukkaW September 25, 2020 00:48
SukkaW
SukkaW approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@curbengh curbengh merged commit 3aac49e into hexojs:master Sep 25, 2020
@curbengh curbengh deleted the custom-anchor branch September 25, 2020 01:07
@sinkcup
Copy link

sinkcup commented Sep 25, 2020 •
edited
Loading

Great! Could you release a new tag? so we can npm install it. @SukkaW

@curbengh
Copy link
Contributor Author

to be released tomorrow #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curbengh @coveralls @sinkcup @SukkaW