Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to latest #87

Merged
merged 3 commits into from
Jul 6, 2019
Merged

Switch to latest #87

merged 3 commits into from
Jul 6, 2019

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Jun 2, 2019

remove nodejs 6 support

remove nodejs 6 support
@tomap
Copy link
Contributor Author

tomap commented Jun 2, 2019

note that I did not managed to make this work.
There is still a failing test and I don't know how to fix it

related to hexojs/hexo#3508

@coveralls
Copy link

coveralls commented Jun 2, 2019

Coverage Status

Coverage remained the same at 94.286% when pulling 57ab07a on tomap:dropNodeJs6 into 51721d5 on hexojs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.286% when pulling 97057da on tomap:dropNodeJs6 into 51721d5 on hexojs:master.

@curbengh
Copy link
Contributor

curbengh commented Jun 5, 2019

.expect(200, '')

Change it to

    .expect(200, {})

for compatibility with supertest@4.

also todo (for myself or anyone to submit a separate PR); replace istanbul with nyc (see hexojs/hexo#3570 hexojs/hexo-generator-sitemap#51).

@tomap
Copy link
Contributor Author

tomap commented Jun 6, 2019

@weyusi thank you. it worked!

package.json Outdated Show resolved Hide resolved
@curbengh
Copy link
Contributor

curbengh commented Jun 29, 2019

for appveyor, I suggest [8, 10, 12].
Currently LTS and Stable are 10. LTS usually refers to more than one versions and can lead to minor confusion.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think appveyor setting is even another PR is OK :)

@curbengh curbengh merged commit 474b6a2 into hexojs:master Jul 6, 2019
@yoshinorin yoshinorin added this to the v0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants