-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply pretty_url to url_for & full_url_for #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url_for
& full url_for
implementations are LGTM.
LGTM too. |
how about adding an optional boolean parameter to
I'm assuming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to urgency of 1.6, I don't mind holding off relative_url
to later.
@curbengh |
what about Another idea I just thought of is that making This is useful where |
I think pass a |
I have noticed
url_for
&full_url_for
will not removeindex.html
whiletrailing_index
is disabled. This PR is addressed to make thetrailing_index
behavior more consistent.I haven't apply pretty_url options to
relative_url()
yet because relative_url doesn't requirebind(hexo)
and can not readhexo.config
directly. After we finishrelative_url()
I will make this PR "Ready to Review".