Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export hljs classPrefix options #15

Closed
wants to merge 2 commits into from
Closed

feat: export hljs classPrefix options #15

wants to merge 2 commits into from

Conversation

wuwb
Copy link

@wuwb wuwb commented Jul 22, 2016

No description provided.

Verified

This commit was signed with the committer’s verified signature.
Aaron1011 Aaron Hill
@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage decreased (-0.3%) to 96.096% when pulling c5b219e on eaielo:master into e18c4bd on hexojs:master.

Verified

This commit was signed with the committer’s verified signature.
Aaron1011 Aaron Hill
@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage increased (+0.01%) to 96.386% when pulling a1ef84c on eaielo:master into e18c4bd on hexojs:master.

@demurgos
Copy link
Contributor

This feature is pretty good but you should add some documentation in the README.md.

@ghost
Copy link

ghost commented Nov 2, 2017

This does not cover the base container class, which is hardcoded to be highlight in Hexo, but hljs in current stylesheets. It seems Hexo's structure is overall not quite true to hljs, but changing line 47 to use the selected prefix instead of 'highlight' as class works with the original stylesheets provided by hljs nevertheless.

The one pitfall here is that the class applied to the container would become hljs- and not hljs, or the other way around it'd be hljsnumber instead of hljs-number so I guess the simplest solution would be to automatically append a - to the option passed to hljs while internally using the provided class.

Edit: tried implementing in #29

@NoahDragon
Copy link
Member

Close. Move to #29

@NoahDragon NoahDragon closed this Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants