Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For better performance, I need to set meta_generator to be false???? #3919

Closed
pplmx opened this issue Dec 9, 2019 · 5 comments
Closed

For better performance, I need to set meta_generator to be false???? #3919

pplmx opened this issue Dec 9, 2019 · 5 comments

Comments

@pplmx
Copy link

pplmx commented Dec 9, 2019 •
edited
Loading

hexo version: 4.1.0

Hexo 3.9.0+ inserts the tag automatically; to get the performance benefit, meta_generator: option needs to be disabled,
_config.yml
meta_generator: false
@SukkaW
Copy link
Member

SukkaW commented Dec 9, 2019

We recommend to disable meta_generator in your _config.yml if you have already added meta_generator() in your theme layout.

@pplmx
Copy link
Author

pplmx commented Dec 10, 2019

Okay, I'll check it. Thanks for your reply.

@carl0schen
Copy link

carl0schen commented Dec 10, 2019 •
edited
Loading

If insert meta_generator() and meta_generator: false, My <head> output is:
<meta name="generator" content="Hexo undefined">

Why can't I get the version?

But remove meta_generator() and meta_generator: false, My <head> output is:
<meta name="generator" content="Hexo 4.1.0">

Why is this meta tag displayed correctly?

@curbengh
Copy link
Contributor

curbengh commented Dec 10, 2019 •
edited
Loading

The implementation is incorrect, I'll fix it up.

Edit: #3925

@curbengh curbengh mentioned this issue Dec 10, 2019
Merged
2 tasks
curbengh added a commit to curbengh/hexo-site that referenced this issue Dec 10, 2019
@curbengh
news(hexo 4.1): clarify meta_generator helper
8fc6924 
hexojs/hexo#3919
@SukkaW SukkaW mentioned this issue Jan 10, 2020
Closed
2 tasks
@SukkaW
Copy link
Member

SukkaW commented Jan 10, 2020 •
edited
Loading

This issue should be fixed by #4070.

Once theme has used meta_generator(), the meta_generator filter will be disabled automatically .

@dailyrandomphoto dailyrandomphoto mentioned this issue Jan 16, 2020
Closed
2 tasks
@pplmx pplmx closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add prop to helper extension SukkaW/hexo
4 participants
@carl0schen @pplmx @SukkaW @curbengh