Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解决code中存在类似swig语法被错误解析的问题 #1652

Merged
merged 1 commit into from
Dec 21, 2015

Conversation

ksky521
Copy link

@ksky521 ksky521 commented Dec 14, 2015

因为之前冲突了,所以重新提个

@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 14, 2015

 1) Hexo Box Box watch() - create:
     Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

watch方法在node 5以下的版本全都fail了,这是为啥

@ksky521
Copy link
Author

ksky521 commented Dec 15, 2015

自动化case是不是应该更新了,h都加上了headlink,导致case跑错了

@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 15, 2015

目前这个testcase只能让pr提交者自己更新啦= =

@liuhongjiang
Copy link
Contributor

@ksky521 please refer ot this pull request: #1668.
After it was merged, you can rebase your code.

@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 21, 2015

I run the build again which passed travis-ci, and github can merge it auto so @ksky521 don't need to rebase it again.

Xuanwo pushed a commit that referenced this pull request Dec 21, 2015
解决code中存在类似swig语法被错误解析的问题
@Xuanwo Xuanwo merged commit 6b5fad0 into hexojs:master Dec 21, 2015
@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 21, 2015

https://travis-ci.org/hexojs/hexo/builds/98075794
all passed, 😃

@liuhongjiang
Copy link
Contributor

@Xuanwo Please don't merge pull request which has the commit message in Chinese.
All commit message should be in English for the sake of developers from other country.

@Xuanwo
Copy link
Contributor

Xuanwo commented Dec 21, 2015

@liuhongjiang Thoughtful idea, I got it.

@ksky521
Copy link
Author

ksky521 commented Jun 29, 2016

😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants