Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #942 #2348

Merged
merged 5 commits into from
Jan 18, 2017
Merged

Fix issue #942 #2348

merged 5 commits into from
Jan 18, 2017

Conversation

kflu
Copy link
Contributor

@kflu kflu commented Jan 9, 2017

It fixes #942

Before fix:

<meta property="og:image" content="https://example.com/blog/image.JPG">

After fix:

<meta property="og:image" content="https://example.com/blog/2017/01/02/2017-01-02-blog-title/image.JPG">

@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.132% when pulling 58243a2 on kflu:master into 1da7ad5 on hexojs:master.

@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 97.131% when pulling f5e15e0 on kflu:master into 1da7ad5 on hexojs:master.

@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 97.131% when pulling 3562a79 on kflu:master into 1da7ad5 on hexojs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 97.131% when pulling e075c78 on kflu:master into 1da7ad5 on hexojs:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 97.131% when pulling e075c78 on kflu:master into 1da7ad5 on hexojs:master.

@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 97.131% when pulling 91f620b on kflu:master into 1da7ad5 on hexojs:master.

@NoahDragon
Copy link
Member

LGTM

@kflu
Copy link
Contributor Author

kflu commented Jan 17, 2017

@NoahDragon thanks. Is there anything further I need to do to have this merged?

@NoahDragon
Copy link
Member

NoahDragon commented Jan 18, 2017 •
edited
Loading

@kflu 😄 just merged.

@NoahDragon NoahDragon merged commit c927811 into hexojs:master Jan 18, 2017
@NoahDragon NoahDragon mentioned this pull request Mar 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

og:url incorrect when site is put under subdirectory
3 participants
@kflu @coveralls @NoahDragon