Replace String#substring() with String#startsWith() or String#endsWith() #3124
Conversation
…com/segayuu/hexo into substring-to-startswith-or-endswith
Misc: add meta generator injection filter
hexojs#3122) * added command line option `output` to write db.json and _multiconfig.yml to a path provided * fixes for appveyor
…s#3118) * updated config loader to accept absolute paths to config files * fixes for coveralls and codeclimate * refactored isAbsolute() check
|
Since I have not responded for more than a week since I requested a review, I will notify @hexojs/core member once more. |
segayuu
changed the title
segayuu
changed the title
…com/segayuu/hexo into substring-to-startswith-or-endswith
|
@segayuu > If there is no response after one week Why week? Go about 1-2 month? It's normal period for awaiting something important. Also, i see codeclimate issues, mb u can fix them? |
| @@ -0,0 +1,17 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Also, it seems new filter added here. But in pull readme there is nothing about this.
There was a problem hiding this comment.
That change is the result of #3129 being resolved by running git rebase.
|
@ivan-nginx The error issued by codeclimate is complexity. Somebody needs to split the function to fix it. |
And String#indexOf() with String#includes()