Spread function: Hexo built-in plugin blockquote #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Judgment as to whether it is more than one character is done beforehand, there is no need to do it again and there is no need to capture all.
With this code it is sufficient to do a null check on the return value of RegExp#exec() or string#match().
This is equivalent if RegExp has no global flag.
segayuu
force-pushed
the
Spread-Hexo-Tag-plugin-blockquote
branch
from
45be31a
to
c84d587
Compare
|
The issue detected by codeclimate is only an improved part of the issue before PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blockquote built-in plugin is too large as a single function.
Also, most of the code concerns only footer output.
Therefore, we will create a new
parseFooter()to reduce complexity.