feat(toc): seek anchor id from parent nodes when target is not available #3404
Conversation
Signed-off-by: Richard Lea <chigix@zoho.com>
|
@chigix |
|
@yoshinorin Thanks for reviewing. This change is mainly focusing on HTML like the case below: <div id="data-summarise" class="section level2">
<h2>Data Summarise</h2>
<p>...</p>
</div>, where the id is not assigned directly on the heading tag. However, this id anchor is still work for navigating to the target heading. So something mocking the template like the case above could be testing case for this change. |
lib/plugins/helper/toc.js
Outdated
| @@ -21,8 +21,14 @@ function tocHelper(str, options = {}) { | |||
| let lastLevel = 0; | |||
|
|
|||
| headings.each(function() { | |||
| function getId(ele) { | |||
There was a problem hiding this comment.
Please bring this getId function above headings.each(...) scope.
There was a problem hiding this comment.
I see. I'll push tweaks later
There was a problem hiding this comment.
Thanks for your patience with us
Signed-off-by: Richard Lea <chigix@zoho.com>
|
@tcrowe I've pushed correction commits. May I have your review again? |
|
@tcrowe |
|
Hey @yoshinorin I tested it but I can't remember what the result was. Do you have an easy way to get PR branches from contributors? Previously I was pulling from their repo but I think we can pull from PR number. |
|
Hi @tcrowe How about this? git fetch origin pull/3404/head:BRANCHNAME |
|
@yoshinorin Thanks! I'll try that method |
|
Thank you @chigix for the enhancement and @yoshinorin for the PR help 🙌 |
Signed-off-by: Richard Lea chigix@zoho.com
Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated: