Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
twitter:image
is deletable. Isn't it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoshinorin It seems like
og:image
support multiple images whiletwitter:image
only support one image. The docs from twitter do not mention multiple images usage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc is not exactly clear.
"URL of image....Images must..."; image? images?
Anyway, the doc does mention twitter:image fallback to og:image, so I think it's redundant too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SukkaW @curbengh
I found following comments from twitter developers forum.
According to comments. The twitter card use last
og:image
if multipleog:image
tags exists. It's not following ogp specification.They are very old comments (4~6 years ago). I could not find newer information. IMHO we should use
twitter:image
if we can not find more information about this matter.I will merge this if other opinion does not exist after wait a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figure most users would expect the first image, which is the current behavior of
open_graph.js
. Let's keeptwitter:image
for now.