refactor(meta_generator): use template string #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
approved these changes
Aug 31, 2019
|
btw, I just found an edge case for this helper. A more robust approach is to only append to |
/<head>.*?<title>.*?(<\/title>).*?<\/head>/I think this pattern will do the job. I will open another PR. Update @curbengh <html>
<head>
<style>
.foo {
background: url(data:image/svg+xml;utf8,<svg width="500" height="300" xmlns="http://www.w3.org/2000/svg"><g><title>svg</title><rect x="10" y="10" width="200" height="50" style="fill:none; stroke:blue; stroke-width:1px"/></g></svg>);
}
</style>
<title>TITLE</title>
</head>
...
</html>I think it might happened. |
/<head>(?!<\/head>).+?<\/head>/If we have to back to replace |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Only a minor changes, use template string instead of
replace().How to test
Pull request tasks