-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: drop lodash for new-post-path filter #3813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's wrong. Please do not merge yet.
if permalink_defaults
is null exctption occure.
TypeError: Cannot convert undefined or null to object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should set the default value at new_post_path.js#L26.
const permalinkDefaults = config.permalink_defaults || '';
Maybe |
I think it's better than set default value :) |
1 similar comment
* refactor: drop lodash for new-post-path filter * fix: handle null case for new-post-path filter
What does it do?
This PR is part of #3753
How to test
Screenshots
Pull request tasks