Enable "exclude:" and "include:" options for files in asset folder (fix #3881)

[seaoak]

What does it do?

Fix #3881

exlucde: option and include: option in _config.yml is no effect for files in Asset Folder.
These are only effect for files outside of source/_post/
(such as source/foo.jpg, source/foo/bar.jpg).

This behavior does not match its document.
https://hexo.io/docs/configuration#Include-Exclude-Files-or-Folders

This patch fixes this behavior.

How to test

git clone -b feature/enable-exclude-and-include-options-for-files-in-asset-folder https://github.com/seaoak/hexo.git
cd hexo
npm install
npm test

Pull request tasks

• Add test cases for the changes.
• Passed the CI test.

[coveralls]

Coverage increased (+0.002%) to 97.148% when pulling 4775a2c on seaoak:feature/enable-exclude-and-include-options-for-files-in-asset-folder into 2146a03 on hexojs:master.

[curbengh]

To clarify, the issue is that currently exclude: and include: doesn't work on post asset folder?

For example:
source/_posts/a_post/index.md + source/_posts/a_post/foo.jpg

and exclude: **/*.jpg doesn't work, even though it should work in every folder/subfolder of source/. Is my understanding correct?

[seaoak]

@curbengh Yes.
This patch is only for asset files, not for post itself.
To exclude a post, skip_render: option should be used (as described in the sample code in the document).

[curbengh]

_config.yml
post_asset_folder: true

Working:

File structure:
source/_posts/a-post.md
source/_posts/a-post/foo.txt
source/_posts/a-post/_bar.txt

Tested patterns:

• include: '**.txt'
• include: '*.txt'
• include: '**/*.txt
• exclude: '**.txt'
• exclude: '*.txt'
• exclude: '**/*.txt'
• include: '_bar.txt' + exclude: 'foo.txt'

---

Not working

File structure:
source/_posts/a-post.md
source/_posts/a-post/img/foo.txt
source/_posts/a-post/img/_bar.txt

Tested patterns:

• exclude: '**.txt'
• exclude: '**/img/*.txt'

include: '**.txt' did work though.

[curbengh]

@seaoak

We are planning to release 4.1.0, do you think you can fix the exclude: '**/img/*.txt' in time?

I don't mind including this PR with that shortcoming in 4.1.0 (since this PR at current stage already sufficient for #3881), and then address it later in 4.1.1/4.2.0.

[seaoak]

@curbengh I think this PR will target to 4.1.1/4.2.0.

I think that the fix is not easy because subdirectories of asset folders seem to be not considered right way.
I'll continue to investigate codes! 💪

[curbengh]

Current coverage is sufficient for the use case of #3881. Coverage can be improved in future.

[seaoak]

@curbengh Thank you your following.
I'll make a new PR for subdirectories in Assert Folder. 😄