Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(box): handle edge cases for "ignore:" option #3910

Closed

Conversation

dailyrandomphoto
Copy link
Member

@dailyrandomphoto dailyrandomphoto commented Dec 6, 2019

What does it do?

Continue of #3908 (#3904 (comment))

Related: #3904 , #3538

The first commit fails on new edge cases.

ignore: 
  -   # <= null
ignore: 
  -   # <= null
  - /some/path/

or

ignore: 
  - '' # <= empty string

The second commit will resolve this issue.

How to test

git clone -b fix-ignore-null https://github.com/dailyrandomphoto/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 6, 2019

Coverage Status

Coverage remained the same at 97.136% when pulling ce201f9 on dailyrandomphoto:fix-ignore-null into 5d00e02 on hexojs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.136% when pulling 3c93f8f on dailyrandomphoto:fix-ignore-null into 5d00e02 on hexojs:master.

@curbengh
Copy link
Contributor

curbengh commented Dec 7, 2019

Sorry, I think this PR is being too lenient on invalid config.

@curbengh curbengh closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants