Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hexo/index): use Set #4013

Merged
merged 1 commit into from
Dec 30, 2019
Merged

refactor(hexo/index): use Set #4013

merged 1 commit into from
Dec 30, 2019

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Dec 27, 2019

What does it do?

How to test

git clone -b hexo-index-set https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from curbengh December 27, 2019 16:45
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 97.086% when pulling 6336cd9 on SukkaW:hexo-index-set into 4687816 on hexojs:master.

curbengh
curbengh approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I checked the size of layout and there are only 3 elements at most, so using Set shouldn't have any impact.

@SukkaW SukkaW merged commit f332669 into hexojs:master Dec 30, 2019
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@SukkaW
refactor(hexo/index): use Set (hexojs#4013)
d6d5b12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @curbengh