-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(load_theme_config): support alternate theme config #4120
Conversation
b7df89b
to
b07bffd
Compare
}); | ||
|
||
it('_config.[theme].json exists', () => { | ||
const configPath = join(hexo.base_dir, '_config.test_theme.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature will allow other than YAML
format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I just port the feature from load_config
, if Hexo support _config.json
, then _config.test_theme.json
should be supported as well (That's why I include this in test cases)
Currently Line 360 in 6d29793
Which means something like hexo.extend.filter.register('', () => {
let { key } = hexo.theme.config;
// If the key is defined in `theme_config`, it would be null here
}, 0); does not work. Is it possible to merge See also iissnan/hexo-theme-next#328 ink-zone/fexo#157 Update: #4360 |
What does it do?
The part of #3890
How to test
Screenshots
Pull request tasks