Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(youtube_tag): support playlist #4139

Merged
merged 1 commit into from
Feb 23, 2020
Merged

feat(youtube_tag): support playlist #4139

merged 1 commit into from
Feb 23, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Feb 21, 2020 •
edited
Loading

What does it do?

#3267 Add playlist support for youtube tag.

Related documents: https://support.google.com/youtube/answer/171780?hl=en

Usage:

// By default youtube tag will output video
{% youtube [id] %}

// Manually set type
{% youtube [id] 'video' %}
{% youtube [id] 'playlist' %}

How to test

git clone -btag-youtube-playlist https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from a team February 21, 2020 06:21
curbengh
curbengh approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SukkaW SukkaW merged commit 8a010d4 into hexojs:master Feb 23, 2020
@curbengh curbengh mentioned this pull request Mar 6, 2020
Closed
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SukkaW @curbengh