Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/parsing code error in backticks #4229

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

seaoak
Copy link
Member

@seaoak seaoak commented Apr 8, 2020

What does it do?

Fix the issue #4190 and #4220.

Current backtick_code_block filter does not consider a Swig template
which form is a pair of triple backticks in single line.

This patch makes the filter to ignore such lines.

And also the filter mistook triple-backtick as the end of targets
even if there are some extra characters at the head of line.

This patch fixes it too.

How to test

git clone -b bugfix/parsing_code_error_in_backticks https://github.com/seaoak/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW
Copy link
Member

SukkaW commented Apr 8, 2020

What about adding #4190,#4220 related test cases?

SukkaW
SukkaW previously approved these changes Apr 10, 2020
This was linked to issues Apr 10, 2020
@seaoak seaoak force-pushed the bugfix/parsing_code_error_in_backticks branch from 27cd96c to a5c1b2e Compare April 11, 2020 07:02
@seaoak
Copy link
Member Author

seaoak commented Apr 11, 2020

@SukkaW
I only rebase (squash) this branch. Please review.

@seaoak seaoak marked this pull request as ready for review April 11, 2020 07:04
@SukkaW
Copy link
Member

SukkaW commented Apr 11, 2020

LGTM then! I am going to merge this after I triggering a rebuild at travis.


SInce Travis CI fail due to their own issue, I am merging this.

@SukkaW SukkaW merged commit 33a0abe into hexojs:master Apr 11, 2020
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parsing code error in backticks 代码块渲染错误
2 participants