Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts without title should be accessible #4344

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Posts without title should be accessible #4344

merged 1 commit into from
Jun 2, 2020

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Jun 2, 2020

What does it do?

Issue resolved: #4228
See also #3672

How to test

git clone -b revert-3672 https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Jun 2, 2020

Coverage Status

Coverage decreased (-0.02%) to 97.758% when pulling ff56409 on revert-3672 into e5e898c on master.

@SukkaW
Copy link
Member

SukkaW commented Jun 2, 2020

We should retain empty title behavior, as slug might not be needed for every one.

@SukkaW SukkaW merged commit 0127d4d into master Jun 2, 2020
@stevenjoezhang stevenjoezhang deleted the revert-3672 branch June 2, 2020 08:15
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
22 tasks
@luchaoqi
Copy link

luchaoqi commented Aug 16, 2020

We should retain empty title behavior, as slug might not be needed for every one.

Agreed but posts with the empty title are disappearing in the archives before which hexo will take the file name as default title.

@stevenjoezhang
Copy link
Member Author

@luchaoqi Are you using hexo-theme-icarus? Please open an issue here: https://github.com/ppoffice/hexo-theme-icarus/issues

"Posts without title should be accessible." is required by hexo-theme-unit-test

SukkaW added a commit to SukkaW/hexo that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not display the title of the article
4 participants