docs: deprecate config.external_link (boolean) & config.use_date_for_updated #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - to be dropped in future
- to be dropped in future
stevenjoezhang
approved these changes
Jun 23, 2020
SukkaW
approved these changes
Jun 23, 2020
SukkaW
reviewed
Jun 23, 2020
| @@ -11,6 +11,7 @@ function externalLinkFilter(data) { | |||
|
|
|||
| if (typeof EXTERNAL_LINK_POST_CONFIG === 'undefined') { | |||
| if (typeof config.external_link === 'undefined' || typeof config.external_link === 'object' | |||
| // Deprecated: config.external_link boolean option will be removed in future | |||
There was a problem hiding this comment.
In fact we could remove the boolean value support in Hexo 5.0.0, as it was introduced in Hexo 4.0.0.
2 tasks
curbengh
pushed a commit
to curbengh/curbengh.github.io
that referenced
this pull request
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Deprecate old options, to be dropped in the next major release (Hexo 6), not a breaking change for Hexo 5. Retain backward compatibility only for one major version.
Initially I planned to drop
config.external_link: trueso that new option is used,but I noticed the release note didn't mention about deprecation, so the old option is retained for now.
How to test
Screenshots
Pull request tasks