-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(external_link): migrate config during load_config #4414
Conversation
e22a327
to
a4bbd82
Compare
a4bbd82
to
f9b375e
Compare
f9b375e
to
fbed7ed
Compare
fbed7ed
to
10d8388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor breaking change since config.external_link
is modified. It was already a breaking change in #3675, and later attempted to retain original config.external_link
#4134.
However, most probably users won't notice the difference, other than seeing the deprecation message; this only breaks if user has a script or theme that checks truthy value, i.e. if (config.external_link)
, it's now always truthy.
What does it do?
Instead of migrating old boolean format config into object format every time the filter is executed, run the config migration during
load_config
.How to test
Screenshots
Pull request tasks