perf(tag): rendering optimization #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
previously approved these changes
Jul 17, 2020
SukkaW
force-pushed
the
post-tag-render-optimize
branch
from
95eb4b6 to
6f15416
Compare
curbengh
reviewed
Jul 19, 2020
lib/extend/tag.js
Outdated
| @@ -5,7 +5,8 @@ const { cyan } = require('chalk'); | |||
| const { Environment } = require('nunjucks'); | |||
| const Promise = require('bluebird'); | |||
| const placeholder = '\uFFFC'; | |||
| const rPlaceholder = /(?:<|<)!--\uFFFC(\d+)--(?:>|>)/g; | |||
| const rPlaceholder = /<!--\uFFFC(\d+)-->/g; | |||
There was a problem hiding this comment.
I wonder why the previous regex matches < >? I thought <> is only escaped in code block?
There was a problem hiding this comment.
@curbengh IMHO, the regexp here might be copied from post.js in which the <> will be escaped by post renderer (like marked.js & our highlighter).
But inside tag rendering process, there will be no escape at all.
SukkaW
force-pushed
the
post-tag-render-optimize
branch
from
43f38ee to
f439327
Compare
SukkaW
force-pushed
the
post-tag-render-optimize
branch
9 times, most recently
from
0470503 to
cf4ee3c
Compare
SukkaW
force-pushed
the
post-tag-render-optimize
branch
from
cf4ee3c to
d6cb88b
Compare
SukkaW
force-pushed
the
post-tag-render-optimize
branch
3 times, most recently
from
91431ec to
d477f57
Compare
SukkaW
force-pushed
the
post-tag-render-optimize
branch
from
d477f57 to
1d3506b
Compare
|
@seaoak @curbengh @stevenjoezhang The PR is ready for review now. |
curbengh
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
WFM
#### Multi-line raw
{% raw %}
{{ 1+1 }}
{% endraw %}
#### Same line raw
{% raw %}{{ 1+1 }}{% endraw %}
#### Single backquote
`{{ 1+1 }}`
#### Triple backquote
```
{{ 1+1 }}
```
#### Original
{{ 1+1 }}
#### C code
{% codeblock lang:objc %}
[rectangle setX: 10 y: 10 width: 20 height: 20];
{% endcodeblock %}
@curbengh A lot of test cases has been added during pre-hexo-5.0.0 development and I am sure most of the case has been covered in unit test now. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Escape swig tag inside code block only once.
How to test
Screenshots
Pull request tasks