fix: plugin loading conflict with @vercel/nft #4863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Hexo uses browserify's
resolve
to resolve a path of a plugin by default, which is incompatible with@vercel/nft
. See also: vercel/nft#257So we use Node.js's built-in
require.resolve
by default (which is compatible with@vercel/nft
), fallback toresolve.sync
only when the module is not found (or other errors).Since there are no other significant behavior differences (from hexo's usage) between
resolve.sync
andrequire.resolve
, we should dropresolve
from dependency in the future.How to test
Screenshots
Pull request tasks