fix(#4917): suppress YAMLException when load js-yaml #4927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: (#4917)
This PR is just a workaround. Not sure, but I assume this error seems incorrect version resolving of
js-yaml
.How to reproduce?
Dependency tree
Here is the dependency tree after exec
How to reproduce?
section. Certainly,hexo@6.1.0
depends onjs-yaml@4.1.0
and it seems no problem.But, as you know exception occurs when run test. I'm not sure but it seems the
require('js-yaml')
resolves older than the4.0.0
version ofjs-yaml.
.I don't know which is the cause
hexo
,npm
, orjs-yaml
.Others
I'm going to release a patch version
6.1.1
&5.4.1
if this PR accepts.Pull request tasks