Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag/post_link): throw on post_link error #4938

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

xbc5
Copy link
Contributor

@xbc5 xbc5 commented Apr 9, 2022

What does it do?

Throws an error if post_link receives no slug, or finds no post.

Why?

Is it ever okay to push a broken link? CI should fail if the author pushes a broken link (perhaps after a post filename change).

Pull request tasks

  • Add test cases for the changes.

Related

The open issue: #4937

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

How to test

git clone -b feat/throw-post-link https://github.com/xbc5/hexo.git
cd hexo
npm install
npm test

@xbc5 xbc5 changed the title Feat/throw post link feat: throw on post_link error Apr 9, 2022
@coveralls
Copy link

coveralls commented Apr 11, 2022

Coverage Status

Coverage decreased (-0.03%) to 98.031% when pulling 4fdac0d on xbc5:feat/throw-post-link into d9ff35b on hexojs:master.

@xbc5
Copy link
Contributor Author

xbc5 commented Apr 17, 2022

This getting any love?

@stevenjoezhang stevenjoezhang linked an issue Jun 10, 2022 that may be closed by this pull request
2 tasks
@stevenjoezhang stevenjoezhang changed the title feat: throw on post_link error feat(tag/post_link): throw on post_link error Jun 10, 2022
@stevenjoezhang stevenjoezhang merged commit e62f2a6 into hexojs:master Jun 10, 2022
@xbc5 xbc5 deleted the feat/throw-post-link branch June 14, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail build on broken internal link
4 participants