Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete release-drafter #5044

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

yoshinorin
Copy link
Member

What does it do?

Now GitHub can generate release note from PRs.
IMHO we do not need the release-drafter.

https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

Thank you :)

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@yoshinorin yoshinorin marked this pull request as ready for review August 30, 2022 15:49
@github-actions
Copy link

How to test

git clone -b drop/release-drafter https://github.com/yoshinorin/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 98.337% when pulling 49b7a17 on yoshinorin:drop/release-drafter into 354f1f1 on hexojs:master.

Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And this feature (provided by GitHub) eliminates the need of updating existing draft releases every time a commit is pushed!

@yoshinorin yoshinorin merged commit d95d297 into hexojs:master Aug 30, 2022
@yoshinorin yoshinorin deleted the drop/release-drafter branch August 30, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants