Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve coverage #5223

Merged
merged 2 commits into from
Jul 9, 2023
Merged

test: improve coverage #5223

merged 2 commits into from
Jul 9, 2023

Conversation

D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Jun 3, 2023

What does it do?

#3984

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

How to test

git clone -b v7.0.0_cov https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Jun 3, 2023

Coverage Status

coverage: 99.528% (+0.4%) from 99.135% when pulling 5eb549b on D-Sketon:v7.0.0_cov into c9ad8c6 on hexojs:v7.0.0.

@D-Sketon D-Sketon marked this pull request as draft June 3, 2023 13:02
@D-Sketon D-Sketon marked this pull request as ready for review June 3, 2023 13:32
@D-Sketon
Copy link
Member Author

D-Sketon commented Jun 3, 2023

Some statements seem to be unreachable when tested, and it is somewhat difficult to get 100% coverage

@D-Sketon
Copy link
Member Author

D-Sketon commented Jun 3, 2023

Even though statement coverage is approaching 100%, branch coverage is still only 96% and more work is needed

@stevenjoezhang stevenjoezhang merged commit 04bc704 into hexojs:v7.0.0 Jul 9, 2023
@D-Sketon D-Sketon deleted the v7.0.0_cov branch October 6, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants