Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL hash support for post_link tag #5356

Merged

Conversation

iliayatsenko
Copy link
Contributor

@iliayatsenko iliayatsenko commented Nov 20, 2023

What does it do?

Supports using post_link tag with urls containing hashes. For example {% post_link my-post-slug#my-hash 'My Linked Post Title' %}.

This PR resolves #5333

Screenshots

--

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

How to test

git clone -b hash_support_for_post_link_tag https://github.com/iliayatsenko/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6928927438

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.536%

Totals Coverage Status
Change from base Build 6787520040: 0.001%
Covered Lines: 9006
Relevant Lines: 9048

💛 - Coveralls

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@yoshinorin yoshinorin merged commit ea4f63c into hexojs:master Dec 2, 2023
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post_link cannot handle anchors
4 participants