Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(highlight): add an option to switch stripIndent #5427

Merged
merged 5 commits into from
Apr 6, 2024
Merged

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Feb 20, 2024

need hexojs/hexo-util#398
fix #5422

What does it do?

add an option to disable stripIndent
issue #5422

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

How to test

git clone -b stripIndent https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 8491386574

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.531%

Totals Coverage Status
Change from base Build 8490441300: 0.001%
Covered Lines: 9329
Relevant Lines: 9373

💛 - Coveralls

@uiolee uiolee changed the title feat(highlight): add an option to disable stripIndent feat(highlight): add an option to switch stripIndent Mar 30, 2024
lib/hexo/default_config.ts Outdated Show resolved Hide resolved
lib/hexo/default_config.ts Outdated Show resolved Hide resolved
Co-authored-by: yoshinorin <yoshinorin.net@outlook.com>
@uiolee uiolee marked this pull request as ready for review March 30, 2024 14:23
@yoshinorin
Copy link
Member

We need to release a new version of https://github.com/hexojs/hexo-util before merging this PR, right?

@uiolee
Copy link
Member Author

uiolee commented Mar 30, 2024 via email

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@uiolee uiolee merged commit d7ad401 into master Apr 6, 2024
17 of 22 checks passed
@uiolee uiolee deleted the stripIndent branch April 6, 2024 02:22
dimaslanjaka pushed a commit to dimaslanjaka/hexo that referenced this pull request Oct 3, 2024
Co-authored-by: yoshinorin <yoshinorin.net@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hexo strips leading spaces in code blocks
3 participants