Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test case for issue #4334 #5465

Merged
merged 2 commits into from
Apr 16, 2024
Merged

test: add test case for issue #4334 #5465

merged 2 commits into from
Apr 16, 2024

Conversation

D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Apr 14, 2024

add test case for #4334

Supersedes #5117

Copy link

How to test

git clone -b test/old https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@D-Sketon D-Sketon marked this pull request as draft April 14, 2024 12:28
@D-Sketon D-Sketon marked this pull request as ready for review April 16, 2024 13:07
@D-Sketon
Copy link
Member Author

D-Sketon commented Apr 16, 2024

done

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uiolee uiolee changed the title test: test issue #4334 test: add test case for issue #4334 Apr 16, 2024
@uiolee uiolee merged commit 4fec0e0 into hexojs:master Apr 16, 2024
23 checks passed
@D-Sketon
Copy link
Member Author

oops, after importing rewire, the coverage drops by 0.5%.

D-Sketon added a commit that referenced this pull request Apr 21, 2024
dimaslanjaka pushed a commit to dimaslanjaka/hexo that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants