feat(load_config): enforce stricter extension checks #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b config https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
SukkaW
requested changes
Dec 23, 2024
stevenjoezhang
changed the title
stevenjoezhang
force-pushed
the
config
branch
from
9c99da5 to
70f68d5
Compare
|
@SukkaW I've updated the code, and now the JSON suffix is also supported. |
SukkaW
requested changes
Dec 24, 2024
| }; | ||
|
|
||
| async function findConfigPath(path: string): Promise<string> { | ||
| const { dir, name } = parse(path); | ||
|
|
||
| const files = await readdir(dir); | ||
| const item = files.find(item => item.startsWith(name)); | ||
| const item = files.find(item => item === name + '.json'); |
There was a problem hiding this comment.
This doesn't make sense. That should be using path.basename(item) === 'config'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I've noticed that Hexo supports searching for configuration files with different suffixes, such as
_config.txtand_config.json. However, this check is very loose, meaning that_config.backupor_config.yml.bakare also considered valid configuration files. This feature can cause confusion and even security issues for users. Typically, users use_config.ymlonly, and in cases of custom usage, they can specifyhexo.config_path. This suggests that there is little need for custom suffixes. Therefore, I recommend removing this feature in the pull request.Screenshots
Pull request tasks