Fix loading deployer of Heroku and OpenShift. #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
When try to deploy to Heroku error happens,
because the deployer of it isn't loaded.
Same for OpenShift's deployer.
Suggestion:
In lib/loaders/entend.js, add a logging for errors at 31th line in
the catch statement. Something like this:
``` javascript
try {
require('../plugins/' + item);
} catch (e){
hexo.log.e("Failed loading: " + item + " for: " + e);
}
```
tommy351
added a commit
that referenced
this pull request
Apr 25, 2014
Fix loading deployer of Heroku and OpenShift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a blog about how I Fixed Hexo's Deployer.
Before this fix:
When trying to deploy blog to Heroku error happens, because the deployer for Heroku isn't loaded.
Same for OpenShift's deployer.
Suggestion:
In
hexo/lib/loaders/entend.js, a logging could be added for errors at 31th line in the catch statement. Because if not the error is hidden by that catch statement.Here's what I added when I was debugging:
If you need anything, just leave me a comment. 😄 #### PS.
Hexo is AWESOME! Great work!
Thanks.