docs: add warn notice for fragment_cache #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
requested changes
Oct 10, 2019
tomap
approved these changes
Oct 12, 2019
curbengh
requested changes
Oct 12, 2019
Apply code suggestions from code review by @curbengh
SukkaW
force-pushed
the
fragment_cache_notice
branch
from
82dfb5d
to
301eb71
Compare
curbengh
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Please read and check followings before submitting a PR.
hexojs/hexo#3738
Some theme developers enable
fragment_cache()for partial that will be different depending on the pages appearing in, which causes some issue. This PR add a warning notice to that.Although we can implement a "smart"
partial()helper (like @ppoffice did in his icarus theme) that every partial will have diffrent cache id based onlocalsthe partial haves, but there is a side-effect that all partials will be cached causing huge memory usage.