-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink some images, and convert some jpg to png #796
Conversation
the build issue come from mozilla/nunjucks#1161 |
It seems yarn install --ignore-engines would solve our issue, or use the lts version of node, as suggested on another pr |
@tomap |
I suggest add imagemin-lint-staged in the lint-staged + husky manner: {
+ "husky": {
+ "hooks": {
+ "pre-commit": "lint-staged"
+ }
+ },
+ "lint-staged": {
+ "*.{png,jpeg,jpg,gif,svg}": ["imagemin-lint-staged", "git add"]
+ }
} so that
|
@tomap @yoshinorin I suggest to move travis discussion to a separate issue #798. |
As the travis-ci is fixed, can wait to see this change merged. 😉 |
# Conflicts: # source/themes/screenshots/Amber.png # source/themes/screenshots/Icarus.png # source/themes/screenshots/syefe.png
Build fixed |
No description provided.