Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: should not directly depend on spirv_cross, spirv_tools, sysgpu #1173

Closed
2 tasks
emidoots opened this issue Mar 6, 2024 · 1 comment
Closed
2 tasks

editor: should not directly depend on spirv_cross, spirv_tools, sysgpu #1173

emidoots opened this issue Mar 6, 2024 · 1 comment
Labels
bug Something isn't working editor Graphical editor and Mach CLI
Milestone
Mach 0.4

Comments

@emidoots
Copy link
Member

emidoots commented Mar 6, 2024

mach-editor's build.zig.zon file should today only have mach as a dependency.

  • sysgpu import has been updated to @import("mach").sysgpu and build.zig.zon no longer references it.
  • Shader compilation logic with spirv-tools/spirv-cross has been moved into mach repository / sygpu code, and editor's build.zig.zon no longer depends on it.
@emidoots emidoots added bug Something isn't working editor Graphical editor and Mach CLI labels Mar 6, 2024
@emidoots emidoots added this to the Mach 0.4 milestone Mar 6, 2024
@emidoots emidoots mentioned this issue Mar 6, 2024
Closed
7 tasks
emidoots added a commit to hexops/mach-editor that referenced this issue Mar 9, 2024
@emidoots
update to Zig 2024.03; disable spirv dependencies
25778db 
Related hexops/mach#1173

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
@emidoots
Copy link
Member Author

Was fixed by removal of editor codebase (will come back later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working editor Graphical editor and Mach CLI
Projects
None yet
Milestone
Mach 0.4
Development

No branches or pull requests
1 participant
@emidoots