Add TestOutputCollection so collections can be tested and TestRepeat for repeats. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork to master
…utput collection stub Seems to generate fine - tools passing tests - although at present it has no assertions - how to generate a "proper" test since the generated collection contents are only guessable from the script so would need some file names to check in the collection from the user?
… and adjusted test outputs
|
@fubar2 can you update the readme / setup.py with the changelog / bump the version? |
|
Ah. Yes - of course - done. |
…ction in import_xml.py to align with the init of TestOutputCollection. Still passes tests :)
fubar2
changed the title
|
Managed to get the testrepeat branch fixed so have merged it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TestOutputCollection and allows the ToolFactory to generate tools with dummy tests for output collections that pass planemo test. Version bumped...
Arguably, needs extension so individual file names expected to be in the collection can be checked - that will require knowledge that we cannot sanely introspect automagically so will need yet more information on the collection tool form section.
Very lightly tested (TM) - just the plotter tool example.
Suggestions appreciated....
TestRepeat added with tests. Also very lightly tested with a real tool.