Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore name option when not used with legacy clients to avoid producing broken output #1211

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 29, 2024

Closes #1208

Copy link

stackblitz bot commented Oct 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: c8a3e3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:35am

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.15%. Comparing base (ad33092) to head (c8a3e3d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/generate/indexFile.ts 60.00% 2 Missing ⚠️
...-ts/src/plugins/@hey-api/services/plugin-legacy.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   73.11%   73.15%   +0.04%     
==========================================
  Files         125      125              
  Lines       17634    17662      +28     
  Branches     1726     1732       +6     
==========================================
+ Hits        12893    12921      +28     
  Misses       4738     4738              
  Partials        3        3              
Flag Coverage Δ
unittests 73.15% <93.87%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Oct 29, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1211
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1211
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1211

commit: c8a3e3d

@mrlubos mrlubos merged commit d2a039b into main Oct 29, 2024
17 checks passed
@mrlubos mrlubos deleted the fix/legacy-name-ignore branch October 29, 2024 12:51
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core files not included in generated types
1 participant