Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make UserConfig interface instead of type #989

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

jacobinu
Copy link
Collaborator

Fixes #661

Similar problems with exporting a type alias:

Seems like this is intentional, explanation can be found here: privatenumber/cleye#11 (comment)

Should we want createClient and defineConfig to take an array we can just make the parameter config type UserConfig | ReadonlyArray<UserConfig>.

Copy link

stackblitz bot commented Aug 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: bc78a42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 5:09am

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (df9c928) to head (bc78a42).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   76.15%   76.15%           
=======================================
  Files          89       89           
  Lines       10953    10953           
  Branches     1111     1111           
=======================================
  Hits         8341     8341           
  Misses       2605     2605           
  Partials        7        7           
Flag Coverage Δ
unittests 76.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Aug 28, 2024

commit: bc78a42

pnpm add https://pkg.pr.new/@hey-api/client-axios@989
pnpm add https://pkg.pr.new/@hey-api/client-fetch@989
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@989

Open in Stackblitz

@mrlubos mrlubos merged commit e7fe5bd into hey-api:main Aug 28, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
@jacobinu jacobinu deleted the fix/config-type-error branch August 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default export of the module has or is using private name 'ClientConfig'.
2 participants