-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reload images or any assets on virtuosa items when scrolled and came back #4201
Comments
/attempt #4201 can i be assigned this? |
@rajdip-b: We appreciate your enthusiasm but since you already have 3 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡 |
/attempt #4201 Options |
As said earlier FCFS based on PRs and it's quality |
My attempts are stuck in validation or dependency :( |
Feel free to attempt any and create PR for it and claim bounties on PR, we not gonna restrict based on attempts |
@bigint can you please provide a bit more info on how to reach the page that you showed in the screen recording? |
oops the video shows a protected endpoint, you can see any profile followers/following to reproduce it |
Screen.Recording.2023-12-12.at.8.53.16.PM.mov |
@bigint would this caching solution work? |
We never wanna load the images again! |
@bigint, Is this not the concept of any virtual list? Elements are removed when not in view and will be re-rendered upon returning to the viewport. |
yeah I think its similar to this thread petyosi/react-virtuoso#298 (comment) |
@bigint is this issue still up |
/attempt #4201 Options |
do you want to store it in cache or something |
/attempt #4201 Options |
Note The user @kriptonian1 is already attempting to complete issue #4201 and claim the bounty. We recommend checking in on @kriptonian1's progress, and potentially collaborating, before starting a new solution. |
@bigint is this still open? |
@bigint what exactly is the issue? I see that the correct cache control headers are already added. The network requests in the browser are expected, because the virtual scrolling library actually mounts/unmounts react components, so the image requests will be there in the network tab, but as long as the Etag is the same, the request will be cached (provided the browser cache is enabled). Is this issue already fixed? ssr.mov |
Screen.Recording.2023-12-12.at.8.33.19.PM.mov
The text was updated successfully, but these errors were encountered: