Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload images or any assets on virtuosa items when scrolled and came back #4201

Closed
bigint opened this issue Dec 12, 2023 · 20 comments
Closed
Assignees

Comments

@bigint
Copy link
Member

bigint commented Dec 12, 2023

Screen.Recording.2023-12-12.at.8.33.19.PM.mov
@bigint bigint added this to Hey 🌺 Dec 12, 2023
@bigint bigint converted this from a draft issue Dec 12, 2023
@rajdip-b
Copy link

/attempt #4201 can i be assigned this?

Copy link

algora-pbc bot commented Dec 12, 2023

@rajdip-b: We appreciate your enthusiasm but since you already have 3 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡

@RutamBhagat
Copy link

RutamBhagat commented Dec 12, 2023

/attempt #4201

Options

@bigint
Copy link
Member Author

bigint commented Dec 12, 2023

As said earlier FCFS based on PRs and it's quality

@rajdip-b
Copy link

As said earlier FCFS based on PRs and it's quality

My attempts are stuck in validation or dependency :(

@bigint
Copy link
Member Author

bigint commented Dec 12, 2023

Feel free to attempt any and create PR for it and claim bounties on PR, we not gonna restrict based on attempts

@RutamBhagat
Copy link

@bigint can you please provide a bit more info on how to reach the page that you showed in the screen recording?
I went to the /staff/users page but it's giving me a 404 error
image

@bigint
Copy link
Member Author

bigint commented Dec 12, 2023

oops the video shows a protected endpoint, you can see any profile followers/following to reproduce it

@bigint
Copy link
Member Author

bigint commented Dec 12, 2023

Screen.Recording.2023-12-12.at.8.53.16.PM.mov

@RutamBhagat
Copy link

RutamBhagat commented Dec 12, 2023

@bigint would this caching solution work?

@bigint
Copy link
Member Author

bigint commented Dec 12, 2023

We never wanna load the images again!

@tarunrajput
Copy link

@bigint, Is this not the concept of any virtual list? Elements are removed when not in view and will be re-rendered upon returning to the viewport.

@RutamBhagat
Copy link

yeah I think its similar to this thread petyosi/react-virtuoso#298 (comment)

@kriptonian1
Copy link

@bigint is this issue still up

@kriptonian1
Copy link

kriptonian1 commented Dec 15, 2023

/attempt #4201

Options

@kriptonian1
Copy link

We never wanna load the images again!

do you want to store it in cache or something

@MrBlackGhostt
Copy link

MrBlackGhostt commented Dec 26, 2023

/attempt #4201

Options

Copy link

algora-pbc bot commented Dec 26, 2023

Note

The user @kriptonian1 is already attempting to complete issue #4201 and claim the bounty. We recommend checking in on @kriptonian1's progress, and potentially collaborating, before starting a new solution.

@bigint bigint self-assigned this Dec 27, 2023
@chintanpuggalok
Copy link

@bigint is this still open?

@abhi12299
Copy link

@bigint what exactly is the issue? I see that the correct cache control headers are already added. The network requests in the browser are expected, because the virtual scrolling library actually mounts/unmounts react components, so the image requests will be there in the network tab, but as long as the Etag is the same, the request will be cached (provided the browser cache is enabled). Is this issue already fixed?

ssr.mov

@algora-pbc algora-pbc bot removed the 💎 Bounty label Feb 7, 2024
@heyxyz heyxyz deleted a comment from algora-pbc bot Feb 7, 2024
@bigint bigint assigned bigint and unassigned bigint Oct 10, 2024
@bigint bigint closed this as completed Oct 11, 2024
@github-project-automation github-project-automation bot moved this to Done in Hey 🌺 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

8 participants