Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise rocket ship 1F680 #118

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal commented Jan 21, 2020

Fixes #113

This change revises the rocket ship emoji from representing the NASA Space Shuttle to a classic rocket ship per the prevailing trend among other Emoji fonts.

@kriskowal kriskowal requested review from b-g and carlinmack January 21, 2020 06:31
Copy link
Contributor

@carlinmack carlinmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you do fix the things in the comments I'll merge it, thanks for the work!

black/svg/1F680.svg Outdated Show resolved Hide resolved
src/travel-places/transport-air/1F680.svg Outdated Show resolved Hide resolved
@carlinmack
Copy link
Contributor

btw if you are interested in further design towards "the prevailing trend among other Emoji fonts" you should have a look at #105 if you'd like :)

This changes the rocket ship emoji from a depiction of the American space shuttle to the iconic vision of a rocket ship styled in the fashion imagined in the science fiction of the 1960's, as is consistent with the prevailing representations in other emoji font decks.
@kriskowal kriskowal force-pushed the kriskowal-rocket-ship branch from 4e00b04 to 589e721 Compare January 22, 2020 02:00
@kriskowal kriskowal marked this pull request as ready for review January 22, 2020 02:01
@kriskowal
Copy link
Member Author

This should be good to "launch". Re-ran the prettifier and static assent generator.

Oh, do let me know if there's a form for copyright assignment.

@kriskowal kriskowal requested a review from carlinmack January 22, 2020 02:17
@carlinmack
Copy link
Contributor

gonna wait for @b-g to merge as he's the top dog so to say. btw in terms of copyright I think by contributing you agree to release under CC BY SA 4.0, however I would love to have a conversation about this topic

@b-g b-g merged commit 589e721 into hfg-gmuend:master Jan 24, 2020
@b-g
Copy link
Member

b-g commented Jan 24, 2020

@kriskowal thanks + merged!

@kriskowal kriskowal deleted the kriskowal-rocket-ship branch January 24, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Science fiction rocket ship
3 participants