Set GITHUB_SHA to correct value for PRs #797
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In re your comment here: actions/dependency-review-action#545 (comment)
This appears to be a bug in https://github.com/gradle/github-dependency-graph-gradle-plugin, which is used indirectly by this project to submit dependencies. I'll file an issue with them to get it fixed, but in the meantime I believe this PR will help.
Unfortunately,
github.sha
is not a good choice for the SHA to use when submitting a dependency snapshot for a PR. In the case of a PR,github.sha
is (IIRC) a hypothetical merge commit, rather than the head SHA for the PR itself.Since what we want is the PR's head SHA, we get that from
github.event.pull_request.head.sha
when that variable is available.See https://github.com/gradle/github-dependency-graph-gradle-plugin#required-environment-variables for configuration reference for the Gradle plugin that submits dependencies.