-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak(php 8.1): fix some php 8.1 issues #40
Conversation
18239ef
to
c487db2
Compare
I don't oppose this generally. However, the change in version requirements for |
hi, |
I updated the |
to prevent php 8.1 deprecation notices also switch to https://github.com/tine-groupware/MAPI.git see hfig/MAPI#40 execute composer: composer require "hfig/mapi:^1.3" "ramsey/uuid ^4.7" "pear/ole ^1.0.0RC9" "ramsey/collection ^1.2"
Could this PR be merged? The current code is currently generating deprecation notices in symfony projects and this PR solves these notices.
|
This PR will raise the project required PHP version to 8.0 (introduces the return pseudotype I can merge a PR that adds a return typed for everything except Once this is done, I agree it's probably time so say bye to PHP7.x and make another release. |
would be great to have this merged. I've manually applied to return types so it won't show the deprecated messages (php 8.3). Works fine with php 8.1.2 and 8.3.12. |
I've merged and tagged the other PR that maintains PHP 7.1 compatibility. PHP7.4 is now so far out of support, shifting the minimum PHP version to 8.1 or 8.2 is not unreasonable. If someone wants to rebase this and do a general dependency update for a minimum PHP 8.1, I will release it as v2.0.0. |
32076bf
to
f5aa9e2
Compare
oops, sorry - did not want to close the PR. a new one should created for the dependency update. |
I don't disagree with closing it - better to open a new one rebased on the current master HEAD with a more comprehensive set of PHP 8.1 hinting/annotating improvements. |
No description provided.