Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number: install from git archive #1423

Closed
dgoeries opened this issue Nov 23, 2021 · 7 comments
Closed

Version number: install from git archive #1423

dgoeries opened this issue Nov 23, 2021 · 7 comments

Comments

@dgoeries
Copy link
Contributor

Hi,

we did try to install by source and noticed that the version is not set correctly (0.0.0). It also appeared that we did not get the corresponding code. Without further checking, our unit tests act differently when installing from source and not via pip or conda.

@keewis
Copy link
Contributor

keewis commented Nov 23, 2021

where did you get the source from?

Installing from a clone of the repository definitely works, but it is known that github's source tarballs do not – they're essentially the output of git archive which breaks setuptools_scm. We could fix that using setuptools_scm_git_archive, though.

@dgoeries
Copy link
Contributor Author

Thanks a lot, yes the pypi seems to work now. Looks like we had a conflict. Would be great to have a number indicator what is installed :-).

@keewis
Copy link
Contributor

keewis commented Nov 23, 2021

Would be great to have a number indicator what is installed

I'm not sure I understand ... can you elaborate?

@dgoeries
Copy link
Contributor Author

Sorry, I mean the version number

@keewis
Copy link
Contributor

keewis commented Nov 23, 2021

oh, okay. The version number can be fixed using setuptools_scm_git_archive. Can you reopen this issue and rename it to something like "install from git archive"? That would make tracking this a bit easier.

@dgoeries dgoeries reopened this Nov 23, 2021
@dgoeries dgoeries changed the title Sources files Version number: install from git archive Nov 23, 2021
@dgoeries
Copy link
Contributor Author

yes of course, thanks again!

@keewis
Copy link
Contributor

keewis commented Nov 23, 2021

great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants