-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of setuptools_scm_git_archive #2057
Conversation
The .git_archival.txt in the sdist is breaking installation with new versions of pip (version comes up 0.0). Support for git archives is baked into setuptools_scm itself now with version 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it all builds
Looks like we have some unrelated image test failures. I'm trying to get a PR together to fix that separately. That and #2056 should get CI green again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this out, built an sdist and pip install *.tar.gz
and it appeared to get the proper version now, whereas before checking out the sdist pip would get 0.0 for the version. So I think this is good.
Do you want to backport this to the v0.20.x branch? I think this could be backported and then we could tag that commit as |
Remove use of setuptools_scm_git_archive
Remove use of setuptools_scm_git_archive
@greglucas Done in #2059. |
We should see if git archive install still works, excluding .git_archival.txt from sdist is necessarry but it might remove installation from git archive all together. Anyway prioritizing pypi installation is right. I think we need to file an issue in setuptools_scm aswell to at least document this or version inference priority. Btw @keewis just saw this affects xarray sdist installation aswell. |
It looks like pypa/setuptools-scm#734 is adding information to the docs (readme). My guess on reading it is that we have broken the version detection when installing from git archives. My question: does this matter to anyone? I've never bothered with this on my other projects. We currently upload proper sdists to PyPI and that's what conda-forge points to. We haven't documented anywhere that people should consider installing from GitHub's auto-generated tarballs. 🤷♂️ I don't want to hold up getting a fixed PyPI sdist out for this, but I'd review and merge a PR that fixes it up. |
Git archives can sometimes be useful if sdists are missing tests, but fortunately, Cartopy's sdists include tests, so we don't need to use the GitHub tarballs. |
@dopplershift I'm ok with this +1 |
The .git_archival.txt in the sdist is breaking installation with new versions of pip (version comes up 0.0). Support for git archives is baked into setuptools_scm itself now with version 7.
Fixes #2053 using the removal of
setuptools_scm_gitarchive
identified as the root cause there.