allow passing python scalars as atol / rtol to isclose #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
bors r+ |
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2020
1068: Run notebooks on docs build r=hgrecco a=keewis As noted in #1044, the notebooks (`pint-pandas.ipynb` and `numpy.ipynb`) were static, so they would have needed manual reruns. This strips the cell output and updates `requirements_docs.txt` so `nbsphinx` can run the notebook when the documentation is built. I checked it with my own RTD instance to make sure this update does not break building the docs. Note that since `pint-pandas` has never been released, it is installed from the github repository. - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors Co-authored-by: Keewis <keewis@posteo.de>
bors bot
added a commit
that referenced
this pull request
Apr 2, 2020
1068: Run notebooks on docs build r=hgrecco a=keewis As noted in #1044, the notebooks (`pint-pandas.ipynb` and `numpy.ipynb`) were static, so they would have needed manual reruns. This strips the cell output and updates `requirements_docs.txt` so `nbsphinx` can run the notebook when the documentation is built. I checked it with my own RTD instance to make sure this update does not break building the docs. Note that since `pint-pandas` has never been released, it is installed from the github repository. - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors Co-authored-by: Keewis <keewis@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
isclosematch the behaviour ofallclose.black -t py36 . && isort -rc . && flake8with no errorsEdit: the diff is slightly bigger because
blacktouched a few files.