-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve remaining doctests, enable doctest in CI #1124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkgwillison
force-pushed
the
fix-last-doctests
branch
from
July 12, 2020 01:53
4b73ae4
to
d2db231
Compare
some configurations in Travis skip optional dependencies, which causes the doctests that rely on them to fail. This fixes that by checking for those dependencies and skipping the affected doctests with :skipif:
clarkgwillison
force-pushed
the
fix-last-doctests
branch
from
July 12, 2020 05:00
0f7595b
to
1da80f4
Compare
clarkgwillison
changed the title
WIP: resolve remaining doctests, enable doctest in CI
Resolve remaining doctests, enable doctest in CI
Jul 12, 2020
@hgrecco this is ready for review |
bors r+ |
Build succeeded: |
awesome, thianks. I am getting an error on read the docs, lack of pint-pandas?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black -t py36 . && isort -rc . && flake8
with no errorsThis PR pushes off fixing the
get_compatible_units(..., group_or_system='...')
feature mentioned in #1115, removing references to it from the docs for now.It also enables doctests in CI now that all remaining doctests are passing